-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIFICPP-1448 - CWEL JSON output #976
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdebreceni
force-pushed
the
MINIFICPP-1448
branch
from
January 15, 2021 09:19
640235b
to
939a6a6
Compare
fgerlits
reviewed
Jan 15, 2021
extensions/windows-event-log/tests/ConsumeWindowsEventLogTests.cpp
Outdated
Show resolved
Hide resolved
extensions/windows-event-log/tests/ConsumeWindowsEventLogTests.cpp
Outdated
Show resolved
Hide resolved
lordgamez
reviewed
Jan 18, 2021
lordgamez
approved these changes
Jan 18, 2021
fgerlits
reviewed
Jan 18, 2021
fgerlits
approved these changes
Jan 18, 2021
adamdebreceni
force-pushed
the
MINIFICPP-1448
branch
from
January 19, 2021 13:51
07e6958
to
9337685
Compare
fgerlits
approved these changes
Jan 19, 2021
szaszm
reviewed
Jan 21, 2021
szaszm
reviewed
Jan 21, 2021
Co-authored-by: Marton Szasz <[email protected]>
szaszm
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.